Skip to content

Remove class-factory from wsgischema.xml for Zope > 6.0 support - #213

Merged
perrinjerome merged 1 commit into
plone:masterfrom
perrinjerome:fix/class-factory
Apr 18, 2026
Merged

Remove class-factory from wsgischema.xml for Zope > 6.0 support#213
perrinjerome merged 1 commit into
plone:masterfrom
perrinjerome:fix/class-factory

Conversation

@perrinjerome

@perrinjerome perrinjerome commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

This was also removed from the original wsgischema from Zope in zopefoundation/Zope#1290

Fixes #212

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #212

I tested that zope starts when running uv run --with zc.buildout buildout -v && ./bin/zopeinstance fg, first with a buildout on the latest released Zope, 6.0:

## buildout from https://zope.readthedocs.io/en/latest/INSTALL.html#using-plone-recipe-zope2instance
[buildout]
extends =
    https://zopefoundation.github.io/Zope/releases/6.0/versions-prod.cfg
parts =
    zopeinstance

[zopeinstance]
recipe = plone.recipe.zope2instance
eggs =
user = admin:adminpassword
http-address = 8080
zodb-temporary-storage = off
###


## develop plone.recipe.zope2instance on this branch
[buildout]
develop =
    ../plone.recipe.zope2instance
[versions]
plone.recipe.zope2instance =

and with the next versions of ZODB and Zope:

## buildout from https://zope.readthedocs.io/en/latest/INSTALL.html#using-plone-recipe-zope2instance
[buildout]
extends =
    https://zopefoundation.github.io/Zope/releases/6.0/versions-prod.cfg
parts =
    zopeinstance

[zopeinstance]
recipe = plone.recipe.zope2instance
eggs =
user = admin:adminpassword
http-address = 8080
zodb-temporary-storage = off
###


## develop plone.recipe.zope2instance on this branch and Zope on current master branch
[buildout]
develop =
    ../plone.recipe.zope2instance
    ../Zope
[versions]
plone.recipe.zope2instance =
Zope =

## next ZODB version
[versions]
ZODB = 6.3

and zope starts in both cases

@perrinjerome
Remove class-factory from wsgischema.xml for Zope > 6.0 support
198187a 
This was also removed from the original wsgischema from Zope in
zopefoundation/Zope#1290

Fixes plone#212
@perrinjerome
perrinjerome requested a review from dataflake April 18, 2026 12:20
dataflake
dataflake approved these changes Apr 18, 2026
View reviewed changes

@dataflake dataflake left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was never documented or used within the context of plone.recipe.zope2instance, anyway.

@perrinjerome

perrinjerome commented Apr 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Yes and also before the recent changes in Zope/ZODB, this configuration was not working, setting it had no effect.

Thanks

@perrinjerome
perrinjerome merged commit e6ffa30 into plone:master Apr 18, 2026
6 checks passed
@dataflake

dataflake commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

@perrinjerome This would be a good time for a release. I can't make a new Zope release before plone.recipe.zope2instance is released with this change.

@perrinjerome

perrinjerome commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

@dataflake I agree that it's a good time for a release, but I don't know who can make one.

@dataflake

dataflake commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

@mauritsvanrees Help 😉

@perrinjerome
perrinjerome deleted the fix/class-factory branch April 20, 2026 14:31
@mauritsvanrees

mauritsvanrees commented Apr 21, 2026

Copy link
Copy Markdown
Member

I have released plone.recipe.zope2instance 9.0.0a2 to PyPI (give it a few minutes).

I should have made a final release probably. But that will happen within a few weeks I expect.

@dataflake

dataflake commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Hoping for a quick release. I am getting complaints that a simple "pip install zope" breaks because it pulls in Zope 6.0 and the incompatible ZODB 6.3. A new Zope release will fix it, but that will break with the current plone.recipe.zope2instance.

@mauritsvanrees

mauritsvanrees commented Apr 21, 2026

Copy link
Copy Markdown
Member

Fair point. I have released 9.0.0 final.

@dataflake

dataflake commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Thank you! I'll roll a new Zope release tomorrow morning then.

@dataflake

dataflake commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Zope 6.1 is released and announced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataflake dataflake dataflake approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scripts broken on Zope master branch

3 participants

@perrinjerome @dataflake @mauritsvanrees